handled all remaining lint warnings (#875)

* Add workaround for 'truthy' warnings in yaml

See https://github.com/adrienverge/yamllint/issues/158
for some more discussion

* Check each yamllint line length warning and clearly markup those which cannot be easily folded into shorter lines

.circleci/config.yml

@@ -25,11 +25,13 @@ jobs:
       - checkout
       - run:
           name: Download CMake
+          # yamllint disable rule:line-length
           command: |
             $ProgressPreference = "SilentlyContinue"
             Invoke-WebRequest -URI https://github.com/Kitware/CMake/releases/download/v3.16.4/cmake-3.16.4-win64-x64.zip -OutFile $Env:HOMEPATH\cmake-3.16.4-win64-x64.zip
             Expand-Archive $Env:HOMEPATH\cmake-3.16.4-win64-x64.zip -DestinationPath "$Env:ProgramFiles"
             Rename-Item "$Env:ProgramFiles\cmake-3.16.4-win64-x64" -NewName CMake
+          # yamllint enable rule:line-length
       - run: .ci\install-vcpkg.ps1 "$Env:CIRCLE_WORKING_DIRECTORY"
       - run: .ci\build-project.ps1
 workflows:

.github/workflows/cmake-linux.yml

@@ -1,6 +1,7 @@
 ---
 name: CMake
 
+# yamllint disable-line rule:truthy
 on: [push]
 
 env:
@@ -12,6 +13,7 @@ jobs:
     # The CMake configure and build commands are platform agnostic and should
     # work equally well on Windows or Mac.  You can convert this to a matrix
     # build if you need cross-platform coverage.
+    # yamllint disable-line rule:line-length
     # See: https://docs.github.com/en/free-pro-team@latest/actions/learn-github-actions/managing-complex-workflows#using-a-build-matrix
     runs-on: ${{ matrix.os }}
     strategy:

.github/workflows/tests.yml

@@ -1,6 +1,7 @@
 ---
 name: Testing
 
+# yamllint disable-line rule:truthy
 on:
   push:
   pull_request:
@@ -256,6 +257,8 @@ jobs:
             crossbuild-essential-${{ matrix.arch }}
 
       - name: Configure
+        # The HOST_TRIPLET line is not easily foldable
+        # yamllint disable rule:line-length
         run: |
           # This will warn about CC, but we cannot set CC until we run it :-S
           HOST_TRIPLET=$(dpkg-architecture -a${{ matrix.arch }} -q DEB_HOST_GNU_TYPE)
@@ -265,6 +268,7 @@ jobs:
           ./configure --host $HOST_TRIPLET
           cd packages/debian/
           ./configure EXTN=${{ matrix.arch }}
+        # yamllint enable rule:line-length
 
       - name: Build
         run: |