From 72a53325c59a8d90ce7728e392141e043d6d510a Mon Sep 17 00:00:00 2001 From: Hamish Coleman Date: Mon, 1 Nov 2021 19:02:19 +0000 Subject: [PATCH] The docker build steps are bitrotted since 2019 The `DOCKER_IMAGE_VERSION=` line was modified in commit 4d36f9f6135a1 in 2019 and has been wrong ever since. It is using the shell variable syntax, which does not work in Makefiles. Add a warning message for anyone trying to use it. --- Makefile.in | 1 + 1 file changed, 1 insertion(+) diff --git a/Makefile.in b/Makefile.in index 7abe64d..ac3e3fb 100644 --- a/Makefile.in +++ b/Makefile.in @@ -257,6 +257,7 @@ N2N_COMMIT_HASH=@GIT_REVISION@ default: steps steps: + $(info This code appears to have been bitrotted since 2019 - please let us know if you are using it) if [ "$(TARGET_ARCHITECTURE)" = "arm32v7" ] || [ "$(TARGET_ARCHITECTURE)" = "" ]; then DOCKER_IMAGE_FILENAME="Dockerfile.arm32v7" DOCKER_IMAGE_TAGNAME=$(DOCKER_IMAGE_NAME):$(DOCKER_IMAGE_VERSION)-arm32v7 make build; fi if [ "$(TARGET_ARCHITECTURE)" = "x86_64" ] || [ "$(TARGET_ARCHITECTURE)" = "" ]; then DOCKER_IMAGE_FILENAME="Dockerfile.x86_64" DOCKER_IMAGE_TAGNAME=$(DOCKER_IMAGE_NAME):$(DOCKER_IMAGE_VERSION)-x86_64 make build; fi